-
Notifications
You must be signed in to change notification settings - Fork 949
Use dict
instead of print
to test callable without signature
#3478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dict
instead of print
to test callable without signature
#3478
Conversation
In Python 3.11, `inspect.signature(print)` no longer raises ValueError. Fixes: jupyter-widgets#3459
Would it make sense to add Python 3.11 to the CI? |
Sure. Would you mind adding it to ipywidgets/.github/workflows/tests.yml Line 91 in 474bbc9
From https://til.simonwillison.net/github-actions/python-3-11, it seems that just adding |
Yes,
We might need to also update ipywidgets/.github/workflows/tests.yml Line 96 in 474bbc9
actions/setup-python@v2
|
Should I open a new PR? I can also add it here as both changes are related to Python 3.11. |
I think adding it here makes a lot of sense. And if you add it here, we'll get to see that your change makes tests pass for Python 3.11 too. Thanks! |
All green! |
Awesome, thank you! |
@meeseeksdev please backport to 7.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…st callable without signature
Backport PR #3478 on branch 7.x (Use dict instead of print to test callable without signature)
Backported in #3480 |
In Python 3.11,
inspect.signature(print)
no longer raisesValueError.
Fixes: #3459