Skip to content

Add a binder link to the top of notebooks in the docs #3164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2021

Conversation

@ianhi ianhi added the docs label Mar 18, 2021
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch ianhi/ipywidgets/binder-on-page

@ianhi
Copy link
Contributor Author

ianhi commented Mar 18, 2021

@ianhi
Copy link
Contributor Author

ianhi commented Mar 18, 2021

Oh dang the spaces in the notebook names are wreaking absolute havoc

@ianhi
Copy link
Contributor Author

ianhi commented Mar 18, 2021

Oh dang the spaces in the notebook names are wreaking absolute havoc

Which semirelatedly led to discovering jupyterlab/jupyterlab#9953

@ianhi
Copy link
Contributor Author

ianhi commented Mar 18, 2021

That seems to have fixed both the links. I also added a new line between the two statements as otherwise the binder badge was often left all on its own on the second line which looked lonely.

Finally I switched the links to be lab links

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 8dcf591 into jupyter-widgets:master Mar 19, 2021
@jtpio jtpio added this to the 8.0 milestone Mar 19, 2021
@ianhi ianhi deleted the binder-on-page branch March 19, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add binder links to top of all docs pages
2 participants