Skip to content

Make more of lab manager dependencies optional #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2020

Conversation

vidartf
Copy link
Member

@vidartf vidartf commented Aug 7, 2019

It would make the lab manager more reusable if it had fewer strict requirements. I kept the rendermime dependency strict, as I see no way to use it without this.

Other things that I added since they were related (see individual commits for split):

  • Cleaned up use of types.
  • Fixed an assign in if clause (should have been compare ===).
  • Added strict null checks to lab manager package.

If any of these auxiliary points are contentious at all, just say the word and I will split up the PR.

@jasongrout
Copy link
Member

jasongrout commented Aug 7, 2019

At first glance, this looks great as an evolution of the codebase (we're slowly getting stricter typing)!

@vidartf
Copy link
Member Author

vidartf commented Jan 8, 2020

Let's wait on a rebase after #1734 to make this diff smaller...

@vidartf
Copy link
Member Author

vidartf commented Jan 9, 2020

I cleaned up this PR a lot, so it should now be a lot quicker to review!

@jasongrout
Copy link
Member

Thanks!

@jasongrout jasongrout merged commit 2cffe58 into jupyter-widgets:master Jan 11, 2020
@vidartf vidartf deleted the lab-optionals branch January 13, 2020 08:42
@lock lock bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
@jasongrout jasongrout modified the milestones: Patch release, 8.0 Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants