-
Notifications
You must be signed in to change notification settings - Fork 949
Implement Video and Audio widgets #2162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Video and Audio widgets #2162
Conversation
Lgtm. For the tests to pass you will need to update the spec file as per the test error message. |
I also plan to make an |
facf5b6
to
81b616b
Compare
81b616b
to
cbb67f3
Compare
This looks good to merge. Leaving it open for a bit so that jason or other people can comment. |
Looking good! |
Using multiple |
Also @maartenbreddels we may want to implement something like |
After the in-person discussion with @maartenbreddels and @martinRenou we decided to not add the possibility to have extra sources for the video widgets. I think that eventually, we will add a
|
For Python2 and 3 I use this: try:
from urllib import urlopen # py2
except ImportError:
from urllib.request import urlopen # py3
value = urlopen(url).read() Except that Python2 doesn't give an exception on a 404, and will happily feed you the 404 page. For Python 3 you get a proper exception. For the convenience of this, I suggest we add a |
We discussed further on the means to
and APIs. This should probably be another PR. Merging as per agreement with @jasongrout and @maartenbreddels. |
Implement a Video widget, at first I wanted to synchronize the progress of the video between views, but it turned out that it's quite difficult to do it. There is a
timeupdate
event on HTML video elements, but it's not triggered often enough to synchronize the views.Edit: Also implement an Audio widget.
Image
,Video
andAudio
widgets have a common base class_Media