Skip to content

[WIP] GridBox widget #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WIP] GridBox widget #2064

wants to merge 1 commit into from

Conversation

Madhu94
Copy link
Contributor

@Madhu94 Madhu94 commented May 1, 2018

For #1942

Let me know if this looks fine, I've gone with @SylvainCorlay's suggestion.

@Madhu94 Madhu94 mentioned this pull request May 9, 2018
Closed
@mlucool
Copy link
Contributor

mlucool commented May 17, 2018

Any updates on this?

@SylvainCorlay
Copy link
Member

I plan on reviewing this next week. I am off for a couple of days.

@Madhu94
Copy link
Contributor Author

Madhu94 commented Jun 10, 2018

@SylvainCorlay Did you get time to check this ?

@tonyfast tonyfast mentioned this pull request Jun 23, 2018
Closed
@SylvainCorlay
Copy link
Member

Hey @Madhu94 thanks for this. I have been looking at this yesterday with @jasongrout and have made some experiment on the top of your PR in #2107.

Basically, I am extending layout instead of adding new layout types, besides that, it is the same as what you did, plus I add content to the documentation for the grid layout. The PR includes your commits.

@jasongrout
Copy link
Member

Closed in favor of #2107. If this should remain open, let us know and we can reopen it.

@jasongrout jasongrout closed this Jul 6, 2018
@jasongrout jasongrout added this to the Reference milestone Jul 6, 2018
@lock lock bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
Reference
Development

Successfully merging this pull request may close these issues.
4 participants
@Madhu94 @mlucool @SylvainCorlay @jasongrout