Change float log slider default format to .3g #2014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebasguts
approved these changes
Mar 23, 2018
|
I like this a lot. Specially with |
|
Great, thanks! |
github-actions
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After playing with the float slider for a bit, I realized it is very easy to get very small or large orders of magnitude (duh!). These formats are much more readable using .3g rather than .2f as the default format.
Also, I added it to the widget list doc page.
CC @sebasguts - what do you think about changing the default format? For example,
FloatLogSlider(min=-10, max=10, readout_format='.2f')has a huge number of values that are either difficult to understand (at the max) or just plain not visible (at the min). Changing the format to .3f makes both cases much easier to understand.