-
Notifications
You must be signed in to change notification settings - Fork 949
Make a script you can load which implements the amd embedding. #1629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Perhaps it should be |
Yeah, I like libembed better - implemented in the last commit. |
Let's let tests finish, merge, release, and iterate. |
Great, that means that jupyter-sphinx needs this right: app.add_javascript('https://cdnjs.cloudflare.com/ajax/libs/require.js/2.3.4/require.min.js')
app.add_javascript('https://unpkg.com/@jupyter-widgets/html-manager@%s/dist/libembed-amd.js' % __html_manager_version__)
app.add_javascript('https://unpkg.com/@jupyter-widgets/html-manager@%s/dist/embed-amd.js' % __html_manager_version__) |
Yes, I think so. |
Iterating on this - this may not work. Requirejs is getting the wrong location for picking up the local amd modules. We may need to have a few more script tags. |
Even better idea - bundle all of the defined requirejs modules into one file, which we'll load at once rather than in separate require statements. In the next PR. |
If you manage to come up with just a single file, that loads require when not present, and supports 3rd party that would be a big win btw. |
This is now #1630 |
* bumped version to force install on rtd * bumped version to force install on rtd, take 2 * added require * fix: for ipywidgets7 * following jupyter-widgets/ipywidgets#1629 * fix in import and ipywidgets6 support * following up jupyter-widgets/ipywidgets#1630 * missing newline * now using conf.py config values for more flexibility * mention that the extra configuration options are optional * removed print statements
CC @maartenbreddels.
The goal is to enable this for the amd embedding: