Skip to content

Move the disconnected state display into base widget manager/widget view #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasongrout opened this issue Apr 11, 2017 · 6 comments · Fixed by #1369
Closed

Move the disconnected state display into base widget manager/widget view #1275

jasongrout opened this issue Apr 11, 2017 · 6 comments · Fixed by #1369
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jasongrout
Copy link
Member

In order to have a more consistent UI for widgets not currently connected with a kernel, I think we should move the notion of a disconnected widget into the base widget manager. Right now in the classic notebook, we have a small broken link icon indicating a set of widgets not connected to a kernel. We should have some similar notion for other widget views, or at least the top-level containers.

The widgets formed by a widget manager should be considered broken when a kernel is disconnected, killed, restarted, or dead.

@jasongrout jasongrout added this to the 7.0 milestone Apr 11, 2017
@jasongrout
Copy link
Member Author

Here is the CSS currently applied to show the red broken chain icon:

    content: "\f127"; /* chain-broken */
    font-family: "FontAwesome";
    color: #d9534f;
    top: 3px;
    padding: 3px;

I'm thinking a small absolute positioned div in the upper left of the top-most widget in an output area, with a z-index under the widget (so it doesn't interfere with mouse clicks).

jasongrout added a commit to jasongrout/ipywidgets that referenced this issue Apr 11, 2017
See jupyter-widgets#1275 for bringing this back in a more general way.
jasongrout added a commit to jasongrout/ipywidgets that referenced this issue Apr 13, 2017
See jupyter-widgets#1275 for bringing this back in a more general way.
jasongrout added a commit to jasongrout/ipywidgets that referenced this issue May 19, 2017
@dsblank
Copy link

dsblank commented Jan 27, 2018

What if you didn't set the disconnected state icons until after someone tries to interact with a widget? That is, show the widgets without disconnected icons at first, and if they press a button (for example) then it would set the icons.

Sometimes I like to scroll down to a newly opened notebook to motivate what our goal is (it will take a number of cells to build what we will see in the widget). But all of the disconnected icons make for confusion. Here is a snapshot of what it looks like:

screenshot from 2018-01-27 15-25-47

The only reason to care as far as I can figure out about the widget's disconnected state is if I am trying to interact with it, and it doesn't respond.

It would be fine if the disconnected icons propagated up (for widgets with parents) or to the left (for widgets in a HBox) for a single icon per app-of-widgets. But that looks like a lot of work, and I'm trying to think of something simpler that would help resolve this issue.

@dsblank
Copy link

dsblank commented Jan 27, 2018

Another possibility: insert the connection-indicator class when a widget is displayed, but only the top-most-one (eg, non-recursively). Then there is only one classification per widget/widget-group.

@jasongrout
Copy link
Member Author

Another possibility: insert the connection-indicator class when a widget is displayed, but only the top-most-one (eg, non-recursively). Then there is only one classification per widget/widget-group.

I really like this idea. Definitely +1.

@jasongrout
Copy link
Member Author

Can you open an issue for it?

@jasongrout
Copy link
Member Author

(or a PR would be even better! :).

Thanks for bringing this up.

@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants