🚀 create a selected_visible_cell_iterator property
#511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgunstone
force-pushed
the
340-methods-for-robustly-retrieving-key-of-selected_cells
branch
from
f2f159b to
3fa06a2
Compare
|
The linter failure seems legit: - return SelectionHelper(view_data_object, self.selections, self.selection_mode)
+ return SelectionHelper(
+ view_data_object, self.selections, self.selection_mode
+ ) |
this allows users to use the SelectionHelper on visible data only Signed-off-by: jgunstone <[email protected]>
Signed-off-by: jgunstone <[email protected]> Signed-off-by: jgunstone <[email protected]>
Signed-off-by: jgunstone <[email protected]>
jgunstone
force-pushed
the
340-methods-for-robustly-retrieving-key-of-selected_cells
branch
from
89a9080 to
e34fd11
Compare
martinRenou
approved these changes
May 14, 2024
jgunstone
deleted the
340-methods-for-robustly-retrieving-key-of-selected_cells
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
this allows users to use the SelectionHelper on visible data only.
I require this functionality in
ipyautouiand have previously monkey-patchedDataGridto add it -in the version bump to >1.3 there have been updates to the SelectionHelper thus breaking my patch -
I think that the functionality could be useful to others so it would be great to get it supported by the lib.
the update is very simple (see diff) and doesn't represent an additional maintainence burden.
Issue number of the reported bug or feature request: #340
Testing performed
I monkey-patched DataGrid and added the new features and confirmed it is working.
I was having trouble setting up the dev env in this repo #510 so haven't been able to test the full package.