Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing list_sessions method #26

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented May 10, 2022

#22 introduced a bug by accidentally deleting the list_sessions method.

@Zsailer Zsailer added the bug Something isn't working label May 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@7994444). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage        ?   60.39%           
=======================================
  Files           ?        7           
  Lines           ?      356           
  Branches        ?       75           
=======================================
  Hits            ?      215           
  Misses          ?      124           
  Partials        ?       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7994444...3837a85. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems important. 😄

@Zsailer Zsailer merged commit 16a1a87 into jupyter-server:main May 10, 2022
@Zsailer Zsailer deleted the sync-bug branch May 10, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants