Update typings for Server 2.10.1 and mypy 1.7 #425 (#99)

jupyter-server · Nov 16, 2023 · a368582 · a368582
1 parent 554cfb3
commit a368582
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -31,7 +31,7 @@ repos:
       - id: mdformat
 
   - repo: https://github.com/pre-commit/mirrors-prettier
-    rev: "v3.0.3"
+    rev: "v3.1.0"
     hooks:
       - id: prettier
         types_or: [yaml, html, json]
@@ -56,14 +56,14 @@ repos:
       - id: rst-inline-touching-normal
 
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: "v1.6.1"
+    rev: "v1.7.0"
     hooks:
       - id: mypy
         files: "^jupyter_server_terminals"
         stages: [manual]
         args: ["--install-types", "--non-interactive"]
         additional_dependencies:
-          ["traitlets>=5.13", "jupyter_server>=2.10", "terminado>=0.18"]
+          ["traitlets>=5.13", "jupyter_server>=2.10.1", "terminado>=0.18"]
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
     rev: v0.1.5

diff --git a/jupyter_server_terminals/base.py b/jupyter_server_terminals/base.py
@@ -14,4 +14,4 @@ class TerminalsMixin(ExtensionHandlerMixin):
 
     @property
     def terminal_manager(self) -> TerminalManager:
-        return self.settings["terminal_manager"]  # type:ignore[attr-defined,no-any-return]
+        return self.settings["terminal_manager"]  # type:ignore[no-any-return]