Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate through set of apps in extension_manager.any_activity method #1157

Conversation

mahendrapaipuri
Copy link
Contributor

Fixes #1156

@welcome
Copy link

welcome bot commented Dec 28, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Base: 79.94% // Head: 79.87% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (de59526) compared to base (2fcd759).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1157      +/-   ##
==========================================
- Coverage   79.94%   79.87%   -0.08%     
==========================================
  Files          68       68              
  Lines        8098     8099       +1     
  Branches     1600     1601       +1     
==========================================
- Hits         6474     6469       -5     
- Misses       1201     1206       +5     
- Partials      423      424       +1     
Impacted Files Coverage Δ
jupyter_server/extension/manager.py 92.34% <0.00%> (-0.45%) ⬇️
...ter_server/services/kernels/connection/channels.py 58.59% <0.00%> (-1.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 added the bug label Dec 29, 2022
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 73d5776 into jupyter-server:main Dec 29, 2022
@welcome
Copy link

welcome bot commented Dec 29, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@mahendrapaipuri mahendrapaipuri deleted the bugfix_activity_extension_manager branch December 29, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in extension_manger.any_activity() method in v2 and above
2 participants