Port Notebook PRs patching tornado 6 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zsailer
commented
Sep 27, 2019
Zsailer
commented
Sep 27, 2019
Zsailer
commented
Sep 27, 2019
Zsailer
force-pushed
the
batch-10
branch
2 times, most recently
from
b803161 to
b2a046f
Compare
kevin-bates
reviewed
Sep 27, 2019
| @@ -74,7 +74,7 @@ | |||
| zip_safe = False, | |||
| install_requires = [ | |||
| 'jinja2', | |||
| 'tornado>=4, <6', | |||
| 'tornado>=5.0', | |||
|
Fixing tests. Looks like some things failed the cherry-pick |
Zsailer
force-pushed
the
batch-10
branch
2 times, most recently
from
609c2e1 to
3574e21
Compare
to get testing 6.0 again
for debugging test env
tornado gen.maybe_future is deprecated in >= 5.0 and doesn't accept asyncio coroutine objects or awaitables in general causing failures with tornado 6 on asyncio monkeypatch gen.maybe_future for easier backport to 5.x later, we can update to use our maybe_future throughout
instead of out-of-date dev version
instead of the monkeypatch we did to keep the backport patch small requiring tornado 5 simplifies things a ton because tornado.concurrent.Future is asyncio.Future
3.4 doesn't have isawaitable remove unsupported combinations from test matrix
|
No cleanup necessary. |
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
* prefix heartbeat endpoint * Bump to 0.9.1 * update test * add allow_remote_access * Bump to 0.10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting two PRs: