Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't tag private package or pkg without version #531

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Don't tag private package or pkg without version #531

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2abf9ce
Don't tag private package or pkg without version
fcollonval Oct 15, 2023
48d6a48
Merge branch 'main' into fix/tag-workspace
blink1073 Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions jupyter_releaser/npm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,9 @@ def tag_workspace_packages():
for path in _get_workspace_packages(data):
sub_package_json = path / "package.json"
sub_data = json.loads(sub_package_json.read_text(encoding="utf-8"))
# Don't tag package without version or private
if not sub_data.get("version", "") or sub_data.get("private", False):
continue
tag_name = f"{sub_data['name']}@{sub_data['version']}"
if tag_name in tags:
skipped.append(tag_name)
Expand Down