Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Handling of Workspace Packages #53

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jul 2, 2021

Ensure each sub-package is a directory and has a package.json file.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2021

Codecov Report

Merging #53 (409073a) into master (5b17742) will decrease coverage by 0.95%.
The diff coverage is 78.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   89.03%   88.08%   -0.96%     
==========================================
  Files          15       15              
  Lines        1697     1746      +49     
  Branches      198      213      +15     
==========================================
+ Hits         1511     1538      +27     
- Misses        118      128      +10     
- Partials       68       80      +12     
Impacted Files Coverage Δ
jupyter_releaser/tests/test_functions.py 100.00% <ø> (ø)
jupyter_releaser/changelog.py 88.18% <62.50%> (-2.56%) ⬇️
jupyter_releaser/npm.py 78.83% <65.71%> (-4.91%) ⬇️
jupyter_releaser/lib.py 75.29% <70.00%> (-2.46%) ⬇️
jupyter_releaser/tests/test_cli.py 97.64% <91.66%> (-0.20%) ⬇️
jupyter_releaser/__init__.py 100.00% <100.00%> (ø)
jupyter_releaser/cli.py 92.27% <100.00%> (+0.03%) ⬆️
jupyter_releaser/python.py 91.66% <100.00%> (+3.78%) ⬆️
jupyter_releaser/tests/conftest.py 98.50% <100.00%> (+0.01%) ⬆️
jupyter_releaser/util.py 85.00% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f800ad...409073a. Read the comment docs.

@jtpio jtpio added this to the 0.1 milestone Jul 2, 2021
@jtpio jtpio added the bug Something isn't working label Jul 2, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 5acf2a4 into jupyter-server:master Jul 2, 2021
@jtpio jtpio deleted the fix-workspace-logic branch July 2, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants