Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add silent option #526

Merged
merged 28 commits into from
Nov 20, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
49f7071
Add silent option
fcollonval Sep 14, 2023
91bd9c4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 14, 2023
14323dd
Add action and workflow to remove changelog silent entry
fcollonval Sep 15, 2023
70c9cd0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 15, 2023
6f7b9fe
Make the CI happier
fcollonval Sep 15, 2023
9437da6
Add unit test for remove placeholder
fcollonval Sep 18, 2023
5b0acdc
Fix typing
fcollonval Sep 18, 2023
7531de1
TO REMOVE point to the current branch
fcollonval Sep 18, 2023
e8c9d5d
Fix logic to silent the entry in the changelog only when releasing
fcollonval Sep 18, 2023
07e8dcd
Don't get the changelog for silent GH release in populate release
fcollonval Sep 18, 2023
b6b9d60
Debug populate-release
fcollonval Sep 18, 2023
6dc07a2
Don't request metadata uselessly
fcollonval Sep 18, 2023
351b40e
Ignore release missing known tagged released
fcollonval Sep 18, 2023
bc95ea1
Fix removing placeholder in changelong
fcollonval Sep 18, 2023
e8767fb
Remove debug log
fcollonval Sep 18, 2023
0ad0f61
Revert "TO REMOVE point to the current branch"
fcollonval Sep 18, 2023
b56dfdc
Add documentation
fcollonval Sep 20, 2023
b3e3c0b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 20, 2023
18471a4
Don't print the changelog in the job log if the release is silent
fcollonval Sep 25, 2023
63c70b0
Merge branch 'main' into enh/allow-silent-release
fcollonval Nov 6, 2023
010b558
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 6, 2023
1edfbed
Fix mypy errors
fcollonval Nov 6, 2023
32126aa
Add ruff exception
fcollonval Nov 6, 2023
2c63b7a
[skip ci] Comment new flag silent
fcollonval Nov 16, 2023
cd0154c
[skip ci] Comment new flag in example
fcollonval Nov 16, 2023
2642722
Merge branch 'main' into enh/allow-silent-release
blink1073 Nov 16, 2023
c38ab98
Merge branch 'main' into enh/allow-silent-release
fcollonval Nov 20, 2023
438c428
Fix doc
fcollonval Nov 20, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
  • Loading branch information
pre-commit-ci[bot] committed Sep 14, 2023
commit 91bd9c493cbdf06530d21d2c921cf6364c8a9eb1
10 changes: 9 additions & 1 deletion jupyter_releaser/changelog.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,15 @@ def get_version_entry(


def build_entry(
ref, branch, repo, auth, changelog_path, since, since_last_stable, resolve_backports, silent=False
ref,
branch,
repo,
auth,
changelog_path,
since,
since_last_stable,
resolve_backports,
silent=False,
):
"""Build a python version entry"""
branch = branch or util.get_branch()
Expand Down
19 changes: 4 additions & 15 deletions jupyter_releaser/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -251,10 +251,7 @@ def main(force):

silent_option: t.Any = [
click.option(
"--silent",
envvar="RH_SILENT",
default=False,
help="Set a placeholder in the changelog."
"--silent", envvar="RH_SILENT", default=False, help="Set a placeholder in the changelog."
)
]

Expand Down Expand Up @@ -397,15 +394,7 @@ def build_changelog(
):
"""Build changelog entry"""
changelog.build_entry(
ref,
branch,
repo,
auth,
changelog_path,
since,
since_last_stable,
resolve_backports,
silent
ref, branch, repo, auth, changelog_path, since, since_last_stable, resolve_backports, silent
)


Expand All @@ -431,7 +420,7 @@ def draft_changelog(
dry_run,
post_version_spec,
post_version_message,
silent
silent,
):
"""Create a changelog entry PR"""
lib.draft_changelog(
Expand All @@ -446,7 +435,7 @@ def draft_changelog(
dry_run,
post_version_spec,
post_version_message,
silent
silent,
)


Expand Down
4 changes: 2 additions & 2 deletions jupyter_releaser/lib.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def draft_changelog(
dry_run,
post_version_spec,
post_version_message,
silent
silent,
):
"""Create a changelog entry PR"""
repo = repo or util.get_repo()
Expand Down Expand Up @@ -104,7 +104,7 @@ def draft_changelog(
"post_version_spec": post_version_spec,
"post_version_message": post_version_message,
"expected_sha": current_sha,
"silent": silent
"silent": silent,
}
with tempfile.TemporaryDirectory() as d:
metadata_path = Path(d) / util.METADATA_JSON
Expand Down