Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the authentication to format_pr_entry #489

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Jan 9, 2023

Fixes #490

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 82.10% // Head: 82.10% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (dff3d4a) compared to base (dcaef66).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #489   +/-   ##
=======================================
  Coverage   82.10%   82.10%           
=======================================
  Files          20       20           
  Lines        2816     2817    +1     
  Branches      516      516           
=======================================
+ Hits         2312     2313    +1     
  Misses        373      373           
  Partials      131      131           
Impacted Files Coverage Δ
jupyter_releaser/changelog.py 72.72% <100.00%> (ø)
jupyter_releaser/lib.py 80.68% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 added the bug Something isn't working label Jan 9, 2023
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit e9d498b into jupyter-server:main Jan 9, 2023
@fcollonval fcollonval deleted the patch-1 branch January 9, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

format_pr_entry does not receive the authentication token
2 participants