Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more default python dist checks #481

Merged
merged 11 commits into from
Dec 22, 2022

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 added the enhancement New feature or request label Dec 22, 2022
@blink1073 blink1073 enabled auto-merge (squash) December 22, 2022 15:37
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 82.07% // Head: 82.11% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (1a2658c) compared to base (7c464a6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
+ Coverage   82.07%   82.11%   +0.03%     
==========================================
  Files          20       20              
  Lines        2806     2812       +6     
  Branches      515      516       +1     
==========================================
+ Hits         2303     2309       +6     
  Misses        371      371              
  Partials      132      132              
Impacted Files Coverage Δ
jupyter_releaser/actions/generate_changelog.py 0.00% <ø> (ø)
jupyter_releaser/tests/test_cli.py 98.88% <ø> (ø)
jupyter_releaser/cli.py 87.07% <100.00%> (ø)
jupyter_releaser/python.py 73.25% <100.00%> (+0.63%) ⬆️
jupyter_releaser/tee.py 80.26% <100.00%> (+1.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit 883e072 into jupyter-server:main Dec 22, 2022
@blink1073 blink1073 deleted the add-more-checks branch December 22, 2022 16:36
"--pydist-extra-check-cmds",
envvar="RH_EXTRA_PYDIST_CHECK_CMDS",
default=[
"pipx run 'validate-pyproject[all]' pyproject.toml",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this affect projects that use a root pyproject.toml for configuration and other metadata?

It looks like this might be a bit too strict in some cases. Is there a way to skip that check via the releaser config?

An example run where this affects the check release workflow: https://github.com/jupyterlite/jupyterlite/actions/runs/3764123821/jobs/6398242276

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also seems to have an effect on JupyterLab, although probably good it catches potential issue there:

https://github.com/jupyterlab/jupyterlab/actions/runs/3764228169/jobs/6398454511

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is targeting the pyproject.toml in the checkout dir. Here is an example config for ipykernel.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks for the example 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants