-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more default python dist checks #481
Conversation
Codecov ReportBase: 82.07% // Head: 82.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
==========================================
+ Coverage 82.07% 82.11% +0.03%
==========================================
Files 20 20
Lines 2806 2812 +6
Branches 515 516 +1
==========================================
+ Hits 2303 2309 +6
Misses 371 371
Partials 132 132
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
"--pydist-extra-check-cmds", | ||
envvar="RH_EXTRA_PYDIST_CHECK_CMDS", | ||
default=[ | ||
"pipx run 'validate-pyproject[all]' pyproject.toml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this affect projects that use a root pyproject.toml
for configuration and other metadata?
It looks like this might be a bit too strict in some cases. Is there a way to skip that check via the releaser config?
An example run where this affects the check release workflow: https://github.com/jupyterlite/jupyterlite/actions/runs/3764123821/jobs/6398242276
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also seems to have an effect on JupyterLab, although probably good it catches potential issue there:
https://github.com/jupyterlab/jupyterlab/actions/runs/3764228169/jobs/6398454511
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is targeting the pyproject.toml
in the checkout dir. Here is an example config for ipykernel
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks for the example 👍
Add
validate-pyproject
andcheck-wheel-contents
by default.