Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of dev mode #473

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Conversation

blink1073
Copy link
Contributor

Fixes #472

@blink1073 blink1073 added the bug Something isn't working label Dec 10, 2022
@blink1073 blink1073 changed the title Fix handling of dev minor Fix handling of dev mode Dec 10, 2022
@blink1073 blink1073 enabled auto-merge (squash) December 10, 2022 18:48
@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Base: 81.43% // Head: 82.10% // Increases project coverage by +0.66% 🎉

Coverage data is based on head (f913f2e) compared to base (ceb424c).
Patch coverage: 95.45% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
+ Coverage   81.43%   82.10%   +0.66%     
==========================================
  Files          20       20              
  Lines        2817     2799      -18     
  Branches      515      513       -2     
==========================================
+ Hits         2294     2298       +4     
+ Misses        392      369      -23     
- Partials      131      132       +1     
Impacted Files Coverage Δ
jupyter_releaser/util.py 74.44% <50.00%> (+4.42%) ⬆️
jupyter_releaser/tests/test_cli.py 98.88% <100.00%> (+0.01%) ⬆️
jupyter_releaser/tests/test_functions.py 100.00% <100.00%> (+0.81%) ⬆️
jupyter_releaser/tests/util.py 99.03% <100.00%> (-0.97%) ⬇️
jupyter_releaser/changelog.py 72.72% <0.00%> (-0.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit fdd0712 into jupyter-server:main Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev mode handling is incorrect for minor version bump
1 participant