Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of registry value #39

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Jun 23, 2021

Fixes #38. Follow up to fix a logic error introduced in #34. We must use the given registry value before modifying it for token auth usage.

@blink1073 blink1073 added the bug Something isn't working label Jun 23, 2021
@blink1073 blink1073 added this to the 0.1 milestone Jun 23, 2021
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #39 (8d3c4c4) into master (9129099) will decrease coverage by 0.11%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   88.51%   88.39%   -0.12%     
==========================================
  Files          15       15              
  Lines        1715     1724       +9     
  Branches      205      208       +3     
==========================================
+ Hits         1518     1524       +6     
- Misses        122      124       +2     
- Partials       75       76       +1     
Impacted Files Coverage Δ
jupyter_releaser/lib.py 75.89% <62.50%> (-0.48%) ⬇️
jupyter_releaser/__init__.py 100.00% <100.00%> (ø)
jupyter_releaser/npm.py 80.91% <100.00%> (+0.29%) ⬆️
jupyter_releaser/util.py 85.00% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43ec611...8d3c4c4. Read the comment docs.

@blink1073 blink1073 merged commit 0e521a2 into jupyter-server:master Jun 23, 2021
@blink1073 blink1073 deleted the fix-npm-registry-again branch June 23, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 when publishing the package to npm
3 participants