Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store ref in metadata file #375

Merged
merged 5 commits into from
Sep 12, 2022
Merged

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Sep 12, 2022

Fixes #376

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2022

Codecov Report

Merging #375 (216e7dc) into main (4634184) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   82.92%   82.86%   -0.06%     
==========================================
  Files          21       21              
  Lines        2869     2871       +2     
  Branches      375      376       +1     
==========================================
  Hits         2379     2379              
- Misses        356      357       +1     
- Partials      134      135       +1     
Impacted Files Coverage Δ
jupyter_releaser/cli.py 90.90% <ø> (ø)
jupyter_releaser/lib.py 80.82% <ø> (ø)
jupyter_releaser/util.py 71.59% <0.00%> (-0.35%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@blink1073
Copy link
Contributor Author

@davidbrochart I think I found the bug. Either way there is more logging now.

@fcollonval
Copy link
Member

This will fix #376

@blink1073 blink1073 merged commit 3d0b031 into jupyter-server:main Sep 12, 2022
@blink1073 blink1073 deleted the store-rh-ref branch September 12, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with jupyterlab/jupyterlab and new simplified workflow
3 participants