Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of versions when dev versions are used #341

Merged
merged 3 commits into from
Jul 7, 2022

Conversation

blink1073
Copy link
Contributor

Fixes #340

@blink1073 blink1073 added the bug Something isn't working label Jul 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022

Codecov Report

Merging #341 (4936e0d) into main (eb66cf8) will increase coverage by 0.21%.
The diff coverage is 96.96%.

@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
+ Coverage   83.85%   84.07%   +0.21%     
==========================================
  Files          19       19              
  Lines        2571     2593      +22     
  Branches      341      343       +2     
==========================================
+ Hits         2156     2180      +24     
+ Misses        296      294       -2     
  Partials      119      119              
Impacted Files Coverage Δ
jupyter_releaser/actions/draft_release.py 0.00% <0.00%> (ø)
jupyter_releaser/changelog.py 86.42% <100.00%> (ø)
jupyter_releaser/cli.py 91.51% <100.00%> (+0.06%) ⬆️
jupyter_releaser/lib.py 82.51% <100.00%> (ø)
jupyter_releaser/tests/test_cli.py 99.06% <100.00%> (+<0.01%) ⬆️
jupyter_releaser/tests/test_functions.py 99.11% <100.00%> (+0.04%) ⬆️
jupyter_releaser/util.py 70.56% <100.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb66cf8...4936e0d. Read the comment docs.

@blink1073 blink1073 merged commit face9d6 into jupyter-server:main Jul 7, 2022
@blink1073 blink1073 deleted the fix-dev-version-handling branch July 7, 2022 17:03
blink1073 added a commit to blink1073/jupyter_releaser that referenced this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next and Patch are not properly working if the current version is a dev version
2 participants