Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Changes Needed to Support Lumino #29

Merged
merged 1 commit into from
May 21, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented May 21, 2021

  • Do not require packages to be importable by node (they might contain DOM code or be style-only). Instead, if a "main" attribute exists, make sure the file is available in the dist
  • Normalize handling of workspaces using a helper function

@codecov-commenter
Copy link

Codecov Report

Merging #29 (c7da61c) into master (5b17742) will decrease coverage by 0.52%.
The diff coverage is 83.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   89.03%   88.51%   -0.53%     
==========================================
  Files          15       15              
  Lines        1697     1715      +18     
  Branches      198      205       +7     
==========================================
+ Hits         1511     1518       +7     
- Misses        118      122       +4     
- Partials       68       75       +7     
Impacted Files Coverage Δ
jupyter_releaser/tests/test_cli.py 97.83% <ø> (ø)
jupyter_releaser/tests/test_functions.py 100.00% <ø> (ø)
jupyter_releaser/changelog.py 88.18% <62.50%> (-2.56%) ⬇️
jupyter_releaser/npm.py 80.62% <70.00%> (-3.12%) ⬇️
jupyter_releaser/lib.py 76.36% <80.00%> (-1.39%) ⬇️
jupyter_releaser/__init__.py 100.00% <100.00%> (ø)
jupyter_releaser/cli.py 92.27% <100.00%> (+0.03%) ⬆️
jupyter_releaser/python.py 91.66% <100.00%> (+3.78%) ⬆️
jupyter_releaser/tests/conftest.py 98.50% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a791b4...c7da61c. Read the comment docs.

@blink1073 blink1073 added this to the 0.1 milestone May 21, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 6499aa1 into jupyter-server:master May 21, 2021
@jtpio jtpio deleted the npm-cleanup branch June 22, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants