Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Cleanup in Preparation for Usage with Lumino #27

Merged
merged 1 commit into from
May 20, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented May 20, 2021

  • Do not require tags to exist in the branch for changelog generation
  • Skip node_modules files when checking links
  • Print current changelog entry in draft_changelog
  • Handle workspaces metadata being a dict (jupyterlab currently) or a list (lumino currently)
  • Pin tomlkit since it 0.7.1 breaks tbump

@blink1073 blink1073 added this to the 0.1 milestone May 20, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2021

Codecov Report

Merging #27 (7a07446) into master (5b17742) will decrease coverage by 0.40%.
The diff coverage is 84.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   89.03%   88.63%   -0.41%     
==========================================
  Files          15       15              
  Lines        1697     1716      +19     
  Branches      198      205       +7     
==========================================
+ Hits         1511     1521      +10     
- Misses        118      121       +3     
- Partials       68       74       +6     
Impacted Files Coverage Δ
jupyter_releaser/tests/conftest.py 98.48% <ø> (-0.02%) ⬇️
jupyter_releaser/tests/test_cli.py 97.83% <ø> (ø)
jupyter_releaser/tests/test_functions.py 100.00% <ø> (ø)
jupyter_releaser/changelog.py 88.18% <62.50%> (-2.56%) ⬇️
jupyter_releaser/npm.py 82.30% <70.00%> (-1.44%) ⬇️
jupyter_releaser/lib.py 76.36% <80.00%> (-1.39%) ⬇️
jupyter_releaser/__init__.py 100.00% <100.00%> (ø)
jupyter_releaser/cli.py 92.34% <100.00%> (+0.09%) ⬆️
jupyter_releaser/python.py 91.66% <100.00%> (+3.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbbb83b...7a07446. Read the comment docs.

@blink1073 blink1073 merged commit 73cacdd into jupyter-server:master May 20, 2021
@jtpio jtpio deleted the cleanup branch June 23, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants