Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create forwardport PR after publishing #262

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Create forwardport PR after publishing #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jupyter_releaser/actions/publish_release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@

if release_url:
run(f"jupyter-releaser extract-release {release_url}")
run(f"jupyter-releaser forwardport-changelog {release_url}")

run(f"jupyter-releaser publish-assets {release_url}")

if release_url:
run(f"jupyter-releaser publish-release {release_url}")
run(f"jupyter-releaser forwardport-changelog {release_url}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the release_url (draft URL) will not be available anymore after running publish-release the line before?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @martinRenou who noticed this in https://github.com/martinRenou/jupyter_releaser/runs/5508477170?check_suite_focus=true