-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test empty changelog #243
Test empty changelog #243
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
Codecov Report
@@ Coverage Diff @@
## main #243 +/- ##
==========================================
- Coverage 85.10% 85.09% -0.01%
==========================================
Files 19 19
Lines 2336 2348 +12
Branches 302 303 +1
==========================================
+ Hits 1988 1998 +10
- Misses 251 252 +1
- Partials 97 98 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Just needs a pre-commit
run
Thanks @blink1073! |
Thanks! Starting a new |
solves #131
I'm trying to remove the
...None
from the diff when the changelog is empty. I'm not sure if this is the right solution. I'm a bit lost on how the release works. Meanwhile, I added a test to check if the changelog is empty.