Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test empty changelog #243

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Conversation

hbcarlos
Copy link
Contributor

solves #131

I'm trying to remove the ...None from the diff when the changelog is empty. I'm not sure if this is the right solution. I'm a bit lost on how the release works. Meanwhile, I added a test to check if the changelog is empty.

@welcome
Copy link

welcome bot commented Jan 18, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@hbcarlos hbcarlos marked this pull request as draft January 18, 2022 16:47
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #243 (9b7f157) into main (9d9ec2f) will decrease coverage by 0.00%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   85.10%   85.09%   -0.01%     
==========================================
  Files          19       19              
  Lines        2336     2348      +12     
  Branches      302      303       +1     
==========================================
+ Hits         1988     1998      +10     
- Misses        251      252       +1     
- Partials       97       98       +1     
Impacted Files Coverage Δ
jupyter_releaser/changelog.py 85.45% <33.33%> (-1.59%) ⬇️
jupyter_releaser/tests/test_functions.py 98.63% <100.00%> (+0.08%) ⬆️
jupyter_releaser/tests/util.py 99.25% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9ec2f...9b7f157. Read the comment docs.

@blink1073 blink1073 added the bug Something isn't working label Jan 18, 2022
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just needs a pre-commit run

@hbcarlos
Copy link
Contributor Author

Thanks @blink1073!

@hbcarlos hbcarlos marked this pull request as ready for review January 19, 2022 10:42
@blink1073 blink1073 merged commit 455050d into jupyter-server:main Jan 19, 2022
@welcome
Copy link

welcome bot commented Jan 19, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@hbcarlos hbcarlos deleted the empty_changelog branch January 19, 2022 13:29
@jtpio
Copy link
Member

jtpio commented Jan 19, 2022

Thanks!

Starting a new 0.11.2 release with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants