-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable python target to check-python #238
Conversation
This has been hit in https://github.com/mamba-org/quetz/runs/4759614490 |
Codecov Report
@@ Coverage Diff @@
## main #238 +/- ##
==========================================
- Coverage 85.13% 85.09% -0.04%
==========================================
Files 19 19
Lines 2307 2335 +28
Branches 298 302 +4
==========================================
+ Hits 1964 1987 +23
- Misses 246 251 +5
Partials 97 97
Continue to review full report at Codecov.
|
Perhaps instead we should offer an array of |
I change the PR to be able to pass a list of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Fixes #237 by allowing to define a Python target to be checked through
python -c "import <target>"
instead of using the package name.This can be done through a new cli option
--check-imports
or the env variableRH_CHECK_IMPORTS
.