Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort the list of workspace package versions #218

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Sort the list of workspace package versions #218

merged 2 commits into from
Dec 13, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Dec 10, 2021

At the moment the changelog shows a list of unordered npm packages:

For example: jupyterlab/jupyterlab#11651

This change sorts them so it's a bit more pleasing to the eye.

@jtpio jtpio added the enhancement New feature or request label Dec 10, 2021
@jtpio jtpio added this to the 0.10 milestone Dec 10, 2021
blink1073
blink1073 reviewed Dec 10, 2021
View reviewed changes
jupyter_releaser/npm.py Outdated Show resolved Hide resolved
blink1073
blink1073 approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 1916eee into jupyter-server:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpio @blink1073