Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default branch logic #195

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 22, 2021

Follow-up to #192

This logic was picking up the master branch of the releaser repo.

With this change we remove the explicit branch name and let the forwardport_changelog choose the default branch if needed.

This seems to work with the Publish Release workflow. Not sure about the Full Release.

@jtpio jtpio added this to the 0.9 milestone Oct 22, 2021
@jtpio jtpio added the bug Something isn't working label Oct 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2021

Codecov Report

Merging #195 (aebdf19) into master (e6f503c) will increase coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   84.77%   84.85%   +0.07%     
==========================================
  Files          19       19              
  Lines        2273     2271       -2     
  Branches      280      280              
==========================================
  Hits         1927     1927              
+ Misses        250      248       -2     
  Partials       96       96              
Impacted Files Coverage Δ
jupyter_releaser/actions/publish_release.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6f503c...aebdf19. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 95b14a7 into jupyter-server:master Oct 22, 2021
@jtpio jtpio deleted the default-branch branch October 22, 2021 11:40
@jtpio
Copy link
Member Author

jtpio commented Oct 22, 2021

Gonna make a new 0.9.5 release with this to try it out on a repo right after.

@jtpio
Copy link
Member Author

jtpio commented Oct 22, 2021

This Full Release run went all through with the latest releaser and a repo with main as the default branch: https://github.com/jtpio/jupyter_releaser/runs/3976982945?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants