Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tag name configurable #145

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

blink1073
Copy link
Contributor

Make the tag name used for the release configurable.
Also fix a log message that was using the wrong step name.

@blink1073 blink1073 added the enhancement New feature or request label Sep 10, 2021
@blink1073 blink1073 added this to the 0.6 milestone Sep 10, 2021
@blink1073
Copy link
Contributor Author

cc @Carreau

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2021

Codecov Report

Merging #145 (f708f4d) into master (5af9ea7) will decrease coverage by 0.06%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   85.50%   85.43%   -0.07%     
==========================================
  Files          17       17              
  Lines        2104     2108       +4     
  Branches      253      254       +1     
==========================================
+ Hits         1799     1801       +2     
- Misses        213      215       +2     
  Partials       92       92              
Impacted Files Coverage Δ
jupyter_releaser/tests/test_cli.py 99.16% <ø> (ø)
jupyter_releaser/cli.py 90.69% <75.00%> (+0.03%) ⬆️
jupyter_releaser/lib.py 83.79% <100.00%> (+0.13%) ⬆️
jupyter_releaser/npm.py 79.71% <0.00%> (-1.45%) ⬇️
jupyter_releaser/util.py 69.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af9ea7...f708f4d. Read the comment docs.

@blink1073 blink1073 merged commit e17735c into jupyter-server:master Sep 10, 2021
@blink1073 blink1073 deleted the allow-fail-prep-git branch September 10, 2021 11:03
@blink1073 blink1073 modified the milestones: 0.6, 0.7 Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants