-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON Schema for Config #134
Conversation
Add a JSON schema for allowed config options and use it to validate user options.
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
+ Coverage 85.44% 85.53% +0.08%
==========================================
Files 17 17
Lines 2096 2101 +5
Branches 253 252 -1
==========================================
+ Hits 1791 1797 +6
Misses 213 213
+ Partials 92 91 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
||
if PACKAGE_JSON.exists(): | ||
elif PACKAGE_JSON.exists(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering whether this breaks existing repos that have both a pyproject.toml
and package.json
file? Previously both files would be checked for the configuration, while this doesn't seem to be the case anymore.
This is for example the case in retrolab or the JupyterLab extension cookiecutter:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we should keep the previous behavior of cascading through the files to be able to pick up the config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed as the check release workflow started to fail here: https://github.com/jupyterlab/retrolab/runs/3535195754
Which seems to be related to the hooks not being run.
Add a JSON schema for allowed config options and use it to validate user options.