Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON Schema for Config #134

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

fcollonval
Copy link
Member

Add a JSON schema for allowed config options and use it to validate user options.

Add a JSON schema for allowed config options and use it to validate user options.
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2021

Codecov Report

Merging #134 (30a6b78) into master (21477d9) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   85.44%   85.53%   +0.08%     
==========================================
  Files          17       17              
  Lines        2096     2101       +5     
  Branches      253      252       -1     
==========================================
+ Hits         1791     1797       +6     
  Misses        213      213              
+ Partials       92       91       -1     
Impacted Files Coverage Δ
jupyter_releaser/util.py 69.31% <100.00%> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21477d9...30a6b78. Read the comment docs.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio added this to the 0.5 milestone Sep 7, 2021
@blink1073 blink1073 merged commit 26b2c42 into jupyter-server:master Sep 7, 2021
@blink1073 blink1073 modified the milestones: 0.5, 0.6 Sep 7, 2021

if PACKAGE_JSON.exists():
elif PACKAGE_JSON.exists():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering whether this breaks existing repos that have both a pyproject.toml and package.json file? Previously both files would be checked for the configuration, while this doesn't seem to be the case anymore.

This is for example the case in retrolab or the JupyterLab extension cookiecutter:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we should keep the previous behavior of cascading through the files to be able to pick up the config.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed as the check release workflow started to fail here: https://github.com/jupyterlab/retrolab/runs/3535195754

Which seems to be related to the hooks not being run.

@fcollonval fcollonval deleted the ft/json-config branch January 6, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants