Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Release" from the GitHub Release title #130

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 6, 2021

This is more of a personal preference, but maybe we could drop the "Release" prefix in the GitHub Release title?

image

@codecov-commenter
Copy link

Codecov Report

Merging #130 (f9dfc6e) into master (f55a540) will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   85.52%   85.27%   -0.25%     
==========================================
  Files          17       17              
  Lines        2093     2058      -35     
  Branches      252      252              
==========================================
- Hits         1790     1755      -35     
  Misses        212      212              
  Partials       91       91              
Impacted Files Coverage Δ
jupyter_releaser/lib.py 83.66% <ø> (ø)
jupyter_releaser/cli.py 89.87% <0.00%> (-0.79%) ⬇️
jupyter_releaser/tests/conftest.py 98.37% <0.00%> (-0.14%) ⬇️
jupyter_releaser/tests/util.py 99.05% <0.00%> (-0.01%) ⬇️
jupyter_releaser/tests/test_cli.py 99.16% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55a540...f9dfc6e. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@blink1073 blink1073 added this to the 0.5 milestone Sep 6, 2021
@blink1073 blink1073 merged commit 778d05e into jupyter-server:master Sep 6, 2021
@blink1073 blink1073 modified the milestones: 0.5, 0.6 Sep 7, 2021
@jtpio jtpio deleted the remove-release-title branch September 8, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants