Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Generate Changelog Workflow #106

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

fcollonval
Copy link
Member

Adds a manual workflow to generate a changelog entry
for a repo that either does not use jupyter_releaser or
requires a changelog entry for an older release.
Also supports changelogs written in RST.

Adds a manual workflow to generate a changelog entry
for a repo that either does not use `jupyter_releaser` or
requires a changelog entry for an older release.
Also supports changelogs written in RST.
@fcollonval fcollonval force-pushed the ft/changelog-workflow branch from 2938feb to 868d90b Compare August 16, 2021 11:46
@blink1073 blink1073 added the enhancement New feature or request label Aug 16, 2021
@blink1073 blink1073 added this to the 0.4 milestone Aug 16, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2021

Codecov Report

Merging #106 (981edcd) into master (abb0a60) will increase coverage by 1.40%.
The diff coverage is 82.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   84.91%   86.31%   +1.40%     
==========================================
  Files          16       17       +1     
  Lines        1929     2032     +103     
  Branches      243      240       -3     
==========================================
+ Hits         1638     1754     +116     
+ Misses        198      189       -9     
+ Partials       93       89       -4     
Impacted Files Coverage Δ
jupyter_releaser/actions/draft_release.py 0.00% <0.00%> (ø)
jupyter_releaser/actions/generate-changelog.py 0.00% <0.00%> (ø)
jupyter_releaser/util.py 67.44% <20.00%> (-1.97%) ⬇️
jupyter_releaser/changelog.py 88.07% <40.00%> (-2.59%) ⬇️
jupyter_releaser/lib.py 83.28% <82.35%> (+8.99%) ⬆️
jupyter_releaser/__init__.py 100.00% <100.00%> (ø)
jupyter_releaser/cli.py 90.55% <100.00%> (-0.29%) ⬇️
jupyter_releaser/python.py 91.66% <100.00%> (ø)
jupyter_releaser/tests/conftest.py 98.50% <100.00%> (ø)
jupyter_releaser/tests/test_cli.py 99.16% <100.00%> (+2.62%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7ea1e6...981edcd. Read the comment docs.

@blink1073 blink1073 merged commit d091df6 into jupyter-server:master Aug 16, 2021
@fcollonval fcollonval deleted the ft/changelog-workflow branch August 17, 2021 05:16
fcollonval added a commit to fcollonval/jupyter_releaser that referenced this pull request Aug 18, 2021
Fixes capture of `RH_SINCE` that was disrupted by jupyter-server#106
@jtpio
Copy link
Member

jtpio commented Aug 27, 2021

Nice!

Should we add this new workflow to the list of workflows in README.md? https://github.com/jupyter-server/jupyter_releaser#workflows

@blink1073
Copy link
Contributor

A PR would be most welcome 😄!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants