-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kernel Status #459
Kernel Status #459
Conversation
4e7dd05
to
9e2c241
Compare
…egistration functions
e2d374c
to
e0b311b
Compare
I feel like this is ready to come in but it will be a pain to test locally in terms of the docs build ahead of either #472 or #469 alternative coming in. The purpose of this was to really, get this common functionality inside the library instead of relying on consumers implementing it from the examples. I think this meets that and I have not gone as far as bringing in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few quick thoughts from me! This looks really nice, and I appreciate the documentation as well.
For trying this out, is the best way still to clone locally and set up a local dev environment?
src/options.js
Outdated
@@ -27,8 +27,8 @@ const _defaultOptions = { | |||
stripPrompts: false, | |||
requestKernel: false, | |||
predefinedOutput: true, | |||
mountStatusWidget: true, | |||
mountActivateWidget: true, | |||
mountStatusWidget: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not to make these true by default? If a page doesn't have the thebe-activate
etc class, then this would just not have any effect right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's a no-op when they are not on the page. 👍 I'll set them to true
Co-authored-by: Chris Holdgraf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me...I can't review the JS in depth but it seems reasonable. I'd be +1 on merging this in and seeing how it feels in practice and making iterative improvements from there. WDYT @stevejpurves ?
planning on bringing this in tomorrow then - @moorepants @TimStewartJ your build doesn't have anything relying on the |
No, we're good. We also don't run the tip of master in our plugin, so we can check these things on new releases. This is our code that uses thebe, for reference: https://github.com/LibreTexts/ckeditor-binder-plugin |
Cool - as long as this doesn't disrupt @moorepants and his community then I'm +1 giving this a whirl! |
🚀 |
responding to issue #271 to make first-class support for a Status Widget.
Previously, users had to rely on functions in the examples folder in order to add status fields to their page. In circumstances where a generic status display will fit, this is now provided within thebelab.
The widget is minimally styled and styles can be easily overridden.
This could also be extended to help manage the multiple kernel case requested in #343 and to give more information back on the kernel type.
TODO:
launch
button as separate examples. The launch button showing dynamic library loading