📄 Enable sites with single projects and no project slug #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanc1
force-pushed
the
feat/no-proj-slug
branch
from
b284700 to
4ea7bc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
projectsis not defined inmyst.yml#site, the site build will default toarticle-theme(see: jupyter-book/myst-theme#68) - this site will not have project slug in the URL.This pr also adds
dataUrlto links/xrefs that points to the mdast json - that means we no longer need to construct these urls by appending.jsonto a page. Also, when savingurlfor a file, this checks if the file is the index, and if so, the url is routed to the root, rather than the page slug specifically.