Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for colon fences #54

Closed
rowanc1 opened this issue Jun 24, 2022 · 4 comments
Closed

Support for colon fences #54

rowanc1 opened this issue Jun 24, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@rowanc1
Copy link
Member

rowanc1 commented Jun 24, 2022

Context

A lot of the existing jupyter book content has these, and is not rendered using mystjs.

Proposal

Looking forward to knowing more about where in the current tools we can implement this. I think it might be in the docutils library?

Tasks and updates

No response

@rowanc1 rowanc1 added the enhancement New feature or request label Jun 24, 2022
rowanc1 added a commit to executablebooks/markdown-it-docutils that referenced this issue Jul 27, 2022
@rowanc1 rowanc1 self-assigned this Jul 27, 2022
@agoose77
Copy link
Contributor

Cool! Is the idea to remove the same plugin from https://github.com/executablebooks/markdown-it-myst-extras?

@rowanc1
Copy link
Member Author

rowanc1 commented Jul 27, 2022

Oh man, wish that either @chrisjsewell or I had caught that in the review. Wasn't aware that this was already ported. Thanks for pointing it out.

I think the best thing to do is take it out of docutils, release a new version, and rearrange the import in mystjs.

@rowanc1
Copy link
Member Author

rowanc1 commented Jul 27, 2022

@rowanc1
Copy link
Member Author

rowanc1 commented Jul 27, 2022

Ok, this is all fixed up in #56 and confirmed that it is working! :)

Thanks @agoose77 for the catch here.

@rowanc1 rowanc1 closed this as completed Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants