Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top Level Refactor #90

Merged
merged 24 commits into from
May 28, 2021
Merged

Top Level Refactor #90

merged 24 commits into from
May 28, 2021

Conversation

dfreeman06
Copy link
Contributor

No description provided.

@dfreeman06 dfreeman06 linked an issue Apr 21, 2021 that may be closed by this pull request
overhaul top level interface #89
Closed
4 tasks
sanbales
sanbales reviewed Apr 26, 2021
View reviewed changes
Copy link

@sanbales sanbales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Much more clear what is going on. This will make it so much easier to extend and understand what is going on.

py_src/ipyelk/nx/pipes.py Outdated Show resolved Hide resolved
py_src/ipyelk/nx/pipes.py Outdated Show resolved Hide resolved
py_src/ipyelk/nx/pipes.py Outdated Show resolved Hide resolved
py_src/ipyelk/nx/pipes.py Outdated Show resolved Hide resolved
@dfreeman06 dfreeman06 mentioned this pull request May 24, 2021
Closed
This was linked to issues May 24, 2021
Sprotty Duplicate ID #17
Closed
Extend ElkJSON Validation Rules #56
Closed
@dfreeman06 dfreeman06 changed the title [wip] inital reflowing of top level. Top Level Refactor May 28, 2021
@dfreeman06 dfreeman06 merged commit cd089b3 into master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanbales sanbales sanbales left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

overhaul top level interface Extend ElkJSON Validation Rules Sprotty Duplicate ID
2 participants
@dfreeman06 @sanbales