Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying spotless groovy support on groovy file format checks. #859

Closed
wants to merge 1 commit into from
Closed

Applying spotless groovy support on groovy file format checks. #859

wants to merge 1 commit into from

Conversation

fvgh
Copy link

@fvgh fvgh commented May 22, 2017

Overview

Replaces custom formatting config for Groovy source files by GrEclipse formatting.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@fvgh
Copy link
Author

fvgh commented May 22, 2017

Please have a look at the proposal for #843.
The configuration is provided as Eclipse prefs. If you prefer different file format (xml, properties, ...) let me know.
I adapted the config to match the current groovy code (allowing lists initialization to be 140 characters long).

If you are interested, I can provide another PR applying the GrEclipse to the gradle files.

@fvgh
Copy link
Author

fvgh commented May 22, 2017

Sorry, my M2 proxy concealed the problem Traivs ran into. It seems that I still need a better understanding of a change introduced in spotless. Need to postpone this PR.

@fvgh fvgh closed this May 22, 2017
@fvgh fvgh deleted the issues/843_switch_to_spotless_groovy_formatter branch May 23, 2017 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant