-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Java 9 on Travis CI from failing #598
Conversation
@@ -49,12 +50,14 @@ void getAttributeWithFunctionReturningNullIsEmpty() { | |||
|
|||
@Test | |||
void vendorFromObjectClassIsPresent() { | |||
assumeFalse(System.getProperty("java.version").equals("9-ea"), "Java 9 not supported, yet"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not check that it is equal to 9-ea
but rather that it starts with 9
.
assertTrue(PackageUtils.getAttribute(Object.class, Package::getSpecificationVendor).isPresent()); | ||
assertTrue(PackageUtils.getAttribute(Object.class, Package::getImplementationVendor).isPresent()); | ||
} | ||
|
||
@Test | ||
void versionSystemPropertyEqualsRuntimeClassImplementationVersion() { | ||
assumeFalse(System.getProperty("java.version").equals("9-ea"), "Java 9 not supported, yet"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Changes force pushed. |
Back to three green CI lights. |
FYI: So perhaps that's the reason. But... |
Here's an excerpt from the JDK 9 mailing list:
|
Oops... I linked to documentation about |
And the Javadoc for
|
And the following from the Javadoc for
So, since your test works with |
Yes, we should create a new ticket to address the issue with package versioning metadata on JDK 9. |
Merged into Thanks |
Created separate issue to address versioning metadata from JARs on Java 9 in #600. |
Overview
Assume that two tests using
Class::getPackage::getXyz()
are not executed on Java 9 -- until the reason why those methods returnnull
is understood and fixed. Create new ticket to track this issue?I hereby agree to the terms of the JUnit Contributor License Agreement.