-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow declaring exclusive resources for child nodes #4151
Allow declaring exclusive resources for child nodes #4151
Conversation
c072648
to
933ef57
Compare
.../src/test/java/org/junit/platform/engine/support/descriptor/ResourceLockAnnotationTests.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I only found some minor things.
junit-jupiter-api/src/main/java/org/junit/jupiter/api/parallel/ResourceLockTarget.java
Outdated
Show resolved
Hide resolved
junit-jupiter-api/src/main/java/org/junit/jupiter/api/parallel/ResourceLockTarget.java
Outdated
Show resolved
Hide resolved
@marcphilipp thanks for the review 🙂 Updated according to the comments |
Thank you for your contribution, @vdmitrienko! 👍 After merging, I noticed that the tests were in the wrong package/project so I moved them in c1a976e. |
My pleasure!
Thank you. |
Issue: #3102
Overview
Allow declaring "shared resources" for direct child nodes via the new
@ResourceLock(target = CHILDREN)
attribute.Using the
@ResourceLock(target = CHILDREN)
in a class-level annotation has the same semantics as adding an annotation with the samevalue
andmode
to each test method and nested test class declared in this class.This may improve parallelization when a test class declares a
READ
lock, but only a few methods hold aREAD_WRITE
lock.I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations