Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize method filter and field filter application in search algorithms #3534

Closed
1 task done
sbrannen opened this issue Nov 4, 2023 · 1 comment
Closed
1 task done

Harmonize method filter and field filter application in search algorithms #3534

sbrannen opened this issue Nov 4, 2023 · 1 comment
Assignees
@sbrannen
Labels
component: Platform type: task
Milestone
5.10.1

Comments

@sbrannen
Copy link
Member

sbrannen commented Nov 4, 2023 •
edited
Loading

Overview

After completing #3532, I noticed that the changes made in conjunction with #3498 do not apply the predicate as consistently as in #3532.

Related Issues

Deliverables

  • Consistently apply method predicate in search algorithms analogous to the application of field predicates.
@sbrannen sbrannen added this to the 5.10.1 milestone Nov 4, 2023
@sbrannen sbrannen self-assigned this Nov 4, 2023
sbrannen added a commit to sbrannen/junit5 that referenced this issue Nov 4, 2023
@sbrannen
Harmonize application of method and field filters in search algorithms
87acac4 
This commit consistently applies method predicates in search algorithms
analogous to the application of field predicates.

See junit-team#3498
See junit-team#3532
Closes junit-team#3534
@sbrannen sbrannen mentioned this issue Nov 4, 2023
Closed
sbrannen added a commit to sbrannen/junit5 that referenced this issue Nov 4, 2023
@sbrannen
Harmonize application of method and field filters in search algorithms
8b4ca32 
This commit consistently applies method predicates in search algorithms
analogous to the application of field predicates.

See junit-team#3498
See junit-team#3532
Closes junit-team#3534
sbrannen added a commit that referenced this issue Nov 4, 2023
@sbrannen
Harmonize application of method and field filters in search algorithms
388c5be 
This commit consistently applies method predicates in search algorithms
analogous to the application of field predicates.

See #3498
See #3532
Closes #3534

(cherry picked from commit a670d10)
@sbrannen
Copy link
Member Author

sbrannen commented Nov 4, 2023

This has been merged into main and backported to 5.10.x.

@sbrannen sbrannen mentioned this issue Jan 15, 2024
Closed
sbrannen added a commit that referenced this issue Jan 15, 2024
@sbrannen
Revert "Harmonize application of method and field filters in search a…
2f05a7c 
…lgorithms"

This reverts commit a670d10.

See #3534
See #3553
See #3600
sbrannen added a commit that referenced this issue Jan 15, 2024
@sbrannen
Revert "Harmonize application of method and field filters in search a…
63d464d 
…lgorithms"

This reverts commit a670d10.

See #3534
See #3553
See #3600

(cherry picked from commit 2f05a7c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
component: Platform type: task
Projects
None yet
Milestone
5.10.1
Development

Successfully merging a pull request may close this issue.

Harmonize application of method and field filters in search algorithms sbrannen/junit5
1 participant
@sbrannen