Add builder for Timeout rule. Make Timeout rule designed for extension. #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcooney
force-pushed
the
Timeout-rule-builder
branch
2 times, most recently
from
1896b77 to
216b881
Compare
| } | ||
|
|
||
| /** | ||
| * @param millis the timeout in milliseconds | ||
| * Creates a {@link Timeout} that will timeout a test after the | ||
| * given duratoin, in milliseconds. |
|
Is there a use case for extending |
|
Some of the pull requests for |
kcooney
force-pushed
the
Timeout-rule-builder
branch
2 times, most recently
from
ffdcdff to
dd5140b
Compare
|
LGTM! If we merge this into 4.12 we have to update the release notes as well here: |
kcooney
force-pushed
the
Timeout-rule-builder
branch
from
8d98dc2 to
db82674
Compare
|
@marcphilipp I updated the release notes. PTAL. If it looks good, I'll squash the commits. |
| @Rule public final TestRule timeout = Timeout.builder() | ||
| .withTimeout(10, TimeUnit.SECONDS) | ||
| .withLookingForStuckThread(true) | ||
| .build() |
|
LGTM besides the missing semicolon. :-) |
kcooney
force-pushed
the
Timeout-rule-builder
branch
from
db82674 to
65d08cc
Compare
kcooney
force-pushed
the
Timeout-rule-builder
branch
from
65d08cc to
510d807
Compare
|
Good catch! Thanks. Rebased. Waiting on Travis to build, then feel free to merge. |
marcphilipp
added a commit
that referenced
this pull request
Sep 14, 2014
Add builder for Timeout rule. Make Timeout rule designed for extension.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.