Optimize assertArrayEquals() #924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@junit-team/junit-committers could one of you review? Thanks. |
| /** | ||
| * Gets the length of the array of actual values. | ||
| */ | ||
| int getActualArrayLength(); |
There was a problem hiding this comment.
How about using java.lang.reflect.Array::getLength() for this method and getExpectedArrayLength? Is it expensive as well?
There was a problem hiding this comment.
Ok, I see it was used before...
kcooney
changed the title
|
One of my coworkers wrote some Caliper microbenchmarks for |
| return; | ||
| } | ||
|
|
||
| assertElementsEqual(messagePrefix, comparisonHelper); |
There was a problem hiding this comment.
What do you think about changing this code to
if (!arraysTriviallyEqual(messagePrefix, expecteds, actuals)) {
assertElementsEqual(messagePrefix, comparisonHelper);
}
|
Don't merge this yet; I have some updated stats from the benchmarks |
|
I reran the benchmarks. See my comment in #918 |
These changes speed up comparisons of one dimensional arrays of primatives between 98.0% and 99.8% and speed up comparisons of multi-dimensional arrays between 81.4% and 82.8%
kcooney
force-pushed
the
optimize-array-equals
branch
from
a485707 to
75d80f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids using reflection when calling assertArrayEquals() for all primitive types except float and double. It does increase the amount of duplication in the code, but I've tried to keep the duplicates trivial and to a minimum.