Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for iterable datapoints #658

Merged
merged 2 commits into from
Apr 2, 2013

Conversation

pimterry
Copy link
Contributor

This patch adds support for iterable datapoints, building on my previous work around all this stuff.

@dsaff
Copy link
Member

dsaff commented Apr 1, 2013

Thanks. Two quick high-level notes:

  1. We should probably upgrade some javadoc. It should especially note that iterable methods are invoked for every possible parameter, so expensive iterable methods are a bad idea.
  2. This looks not to merge with HEAD

@pimterry
Copy link
Contributor Author

pimterry commented Apr 1, 2013

Ah yes, sorry, my master it was slightly behind. I've now rebased the first commit over the other changes, and added documentation to @DataPoints to cover the basics of this.

@dsaff
Copy link
Member

dsaff commented Apr 2, 2013

Looks good to me. Thanks! Can you add a release note?

dsaff pushed a commit that referenced this pull request Apr 2, 2013
Added support for iterable datapoints
@dsaff dsaff merged commit b4b1b31 into junit-team:master Apr 2, 2013
@pimterry pimterry deleted the iterable-datapoints branch April 2, 2013 15:26
@pimterry
Copy link
Contributor Author

pimterry commented Apr 2, 2013

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants