--filter option implemented. #647

noel-yap · 2013-03-01T01:11:46Z

Currently SuiteTest.suiteShouldBeOKwithNonDefaultConstructor() fails but I don't know what ought to be done about that. Under what circumstances does it make sense to have a Suite with no SuiteClasses? Suggestions?

I'll also be refactoring out the command line processing as per @kcooney and will writing more tests for the code that has changed.

kcooney · 2013-03-01T04:09:34Z

src/main/java/org/junit/experimental/categories/Categories.java

@@ -304,6 +308,63 @@ private static boolean hasNull(Class<?>... classes) {
            }
            return false;
        }
+
+        private static class CategoryFilterWrapper extends Filter {


Why is this needed? CategoryFilter extends Filter

CategoryFilterWrapper removed. Code changed to use CategoryFilter.

kcooney · 2013-03-01T05:21:46Z

@noel-yap Overall looks very nice. Like the tests :-)

dsaff · 2013-03-01T18:41:36Z

@noel-yap, looking forward to checking this out. Your comments indicate that another commit is on its way, so I may wait to get all the changes at once.

SuiteTest.suiteShouldBeOKwithNonDefaultConstructor() is asserting that since we never try to construct the class to which @RunWith(Suite.class) is attached, we shouldn't do any validation of any constructors we might find on that class. I forget now what the use case is, but if it's possible to not break it, it would be ideal.

noel-yap · 2013-03-01T19:28:39Z

@dsaff , after making some of the changes @kcooney suggested, all tests now pass. I slightly suspect it's from replacing PassThroughFilter with Filter.ALL (since all other changes have been more aesthetic), but even that change doesn't look like it does much different. Anyway, all tests pass now so I'm not gonna investigate further.

noel-yap · 2013-03-01T22:29:14Z

Some stuff I still need to do:

JavaDoc
tests for new code (yeah, I didn't TDD this)
factor out the command line parsing

Some open issues:

Is it OK to introduce a dependency on a third-party command-line parser? I'm guessing it's not OK, but I don't want to make assumptions.

dsaff · 2013-03-01T23:29:24Z

@noel-yap,

Yes, I'd really prefer to avoid a third-party command-line parser. My hope (fingers crossed) is that we can keep it simple enough to make rolling our own cost-effective.

kcooney · 2013-03-02T02:55:59Z

src/main/java/org/junit/experimental/categories/Categories.java

+                List<Class<?>> categoryClasses = new ArrayList<Class<?>>();
+
+                for (String category : categories.split(",")) {
+                    Class<?> categoryClass = Class.forName(category);


Here you are using Class.forName() instead of the context class loader

Fixed.

Fixed the one in JUnitCore, too.

"--filter arg" support added (as opposed to "--filter=arg"). Command line parser factored into JUnitCommandLineParser class. Unit tests added.

dsaff · 2013-03-07T16:34:03Z

@noel-yap,

Looks like this has drifted against HEAD. Can you pull/merge/push? Thanks.

Conflicts: src/test/java/org/junit/tests/AllTests.java

kcooney · 2013-03-10T03:35:39Z

src/main/java/org/junit/experimental/categories/ExcludeCategories.java

+ */
+public final class ExcludeCategories extends CategoryFilterFactory {
+    @Override
+    public Filter createFilter(Class<?>[] categories) {


Could you use varargs here?

dsaff · 2013-05-29T20:02:58Z

@noel-yap, thanks for the updates. It may be a day or two before I can review again.

noel-yap · 2013-06-04T23:37:48Z

@dsaff , ping.

dsaff · 2013-06-05T00:42:07Z

Thanks. Merging. Can you add a section to the release notes at https://github.com/junit-team/junit/wiki/4.12-release-notes? Thanks.

--filter option implemented.

marcphilipp · 2013-06-05T13:20:49Z

The Jenkins build failed after merging this pull request:

[ERROR] https://junit.ci.cloudbees.com/job/JUnit/ws/src/main/java/org/junit/experimental/categories/CategoryFilterFactory.java:[22,5] method does not override a method from its superclass

See https://junit.ci.cloudbees.com/job/JUnit/46/console for details.

noel-yap · 2013-06-05T13:44:27Z

I'll get on it ASAP.
On Jun 5, 2013 6:22 AM, "Marc Philipp" [email protected] wrote:

The Jenkins build failed after merging this pull request:

[ERROR]
https://junit.ci.cloudbees.com/job/JUnit/ws/src/main/java/org/junit/experimental/categories/CategoryFilterFactory.java:[22,5]
method does not override a method from its superclass

See https://junit.ci.cloudbees.com/job/JUnit/46/console for details.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/647#issuecomment-18974939
.

noel-yap · 2013-06-05T17:33:57Z

@marcphilipp and @dsaff , I am unable to reproduce this error. Also, CategoryFilterFactory implements FilterFactory which is part of the pull request so I'm not sure how this error can be occurring.

I looked through the workspace in https://junit.ci.cloudbees.com/job/JUnit/ and both https://junit.ci.cloudbees.com/job/JUnit/ws/src/main/java/org/junit/experimental/categories/CategoryFilterFactory.java/*view*/ and https://junit.ci.cloudbees.com/job/JUnit/ws/src/main/java/org/junit/runner/FilterFactory.java/*view*/ look good. Any ideas what may be causing this error?

Is it complaining about the @OverRide annotation?

marcphilipp · 2013-06-05T18:41:20Z

We're still using JDK5 in order to stay useable by "old" projects. In JDK5 you cannot annotate a method that implements an interface method with @Override.

Does it compile in Eclipse?

noel-yap · 2013-06-05T19:03:07Z

I use IntelliJ and it compiles fine there as well as from the command line.
I'll take out the annotation ASAP.
On Jun 5, 2013 11:41 AM, "Marc Philipp" [email protected] wrote:

We're still using JDK5 in order to stay useable by "old" projects. In JDK5
you cannot annotate a method that implements an interface method with
@OverRide.

Does it compile in Eclipse?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/647#issuecomment-18998756
.

dsaff · 2013-06-05T19:18:51Z

Thanks, @noel-yap. I'm going on vacation in a couple hours--any chance of a pull request before then? Thanks!

noel-yap · 2013-06-05T20:01:25Z

I just pushed an update.

On Wed, Jun 5, 2013 at 12:19 PM, David Saff [email protected]:

Thanks, @noel-yap https://github.com/noel-yap. I'm going on vacation in
a couple hours--any chance of a pull request before then? Thanks!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/647#issuecomment-19001831
.

marcphilipp · 2013-06-05T20:04:14Z

Your commit doesn't show up in this pull request, probably because it has already been merged. I think you have to create a new pull request.

noel-yap · 2013-06-05T20:10:30Z

Done.

On Wed, Jun 5, 2013 at 1:04 PM, Marc Philipp [email protected]:

Your commit doesn't show up in this pull request, probably because it has
already been merged. I think you have to create a new pull request.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/647#issuecomment-19004630
.

marcphilipp · 2013-06-05T20:43:36Z

Unfortunately, there are a couple more of those in the test source folder:

[ERROR] /scratch/jenkins/workspace/JUnit/src/test/java/org/junit/experimental/categories/CategoryFilterFactoryTest.java:[45,25] createFilter(java.lang.Class[]) in org.junit.experimental.categories.CategoryFilterFactoryTest.CategoryFilterFactoryStub cannot override createFilter(java.lang.Class...) in org.junit.experimental.categories.CategoryFilterFactory; overriding method is missing '...'
[ERROR] /scratch/jenkins/workspace/JUnit/src/test/java/org/junit/experimental/categories/CategoryFilterFactoryTest.java:[45,25] createFilter(java.lang.Class[]) in org.junit.experimental.categories.CategoryFilterFactoryTest.CategoryFilterFactoryStub cannot override createFilter(java.lang.Class...) in org.junit.experimental.categories.CategoryFilterFactory; overriding method is missing '...'
[ERROR] /scratch/jenkins/workspace/JUnit/src/test/java/org/junit/runner/FilterFactoriesTest.java:[68,9] method does not override a method from its superclass
[ERROR] /scratch/jenkins/workspace/JUnit/src/test/java/org/junit/runner/FilterFactoriesTest.java:[75,9] method does not override a method from its superclass
[ERROR] /scratch/jenkins/workspace/JUnit/src/test/java/org/junit/runner/JUnitCommandLineParseResultTest.java:[139,9] method does not override a method from its superclass

noel-yap · 2013-06-05T23:04:35Z

I think the I caught the rest in the latest pull request. Let me know if
there's still brokenness.

Thanks,
Noel
On Jun 5, 2013 1:44 PM, "Marc Philipp" [email protected] wrote:

Unfortunately, there are a couple more of those in the test source folder:

[ERROR]
/scratch/jenkins/workspace/JUnit/src/test/java/org/junit/experimental/categories/CategoryFilterFactoryTest.java:[45,25]
createFilter(java.lang.Class[]) in org.junit.experimental.categories.CategoryFilterFactoryTest.CategoryFilterFactoryStub cannot override createFilter(java.lang.Class...) in
org.junit.experimental.categories.CategoryFilterFactory; overriding method
is missing '...'
[ERROR]
/scratch/jenkins/workspace/JUnit/src/test/java/org/junit/experimental/categories/CategoryFilterFactoryTest.java:[45,25]
createFilter(java.lang.Class[]) in org.junit.experimental.categories.CategoryFilterFactoryTest.CategoryFilterFactoryStub cannot override createFilter(java.lang.Class...) in
org.junit.experimental.categories.CategoryFilterFactory; overriding method
is missing '...'
[ERROR]
/scratch/jenkins/workspace/JUnit/src/test/java/org/junit/runner/FilterFactoriesTest.java:[68,9]
method does not override a method from its superclass
[ERROR]
/scratch/jenkins/workspace/JUnit/src/test/java/org/junit/runner/FilterFactoriesTest.java:[75,9]
method does not override a method from its superclass
[ERROR]
/scratch/jenkins/workspace/JUnit/src/test/java/org/junit/runner/JUnitCommandLineParseResultTest.java:[139,9]
method does not override a method from its superclass

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/647#issuecomment-19007115
.

kcooney · 2013-06-06T01:40:40Z

You could verify locally by running the tests in ant
On Jun 5, 2013 4:04 PM, "Noel Yap" [email protected] wrote:

I think the I caught the rest in the latest pull request. Let me know if
there's still brokenness.

Thanks,
Noel
On Jun 5, 2013 1:44 PM, "Marc Philipp" [email protected] wrote:

Unfortunately, there are a couple more of those in the test source
folder:

[ERROR]

/scratch/jenkins/workspace/JUnit/src/test/java/org/junit/experimental/categories/CategoryFilterFactoryTest.java:[45,25]

createFilter(java.lang.Class<?>[]) in

org.junit.experimental.categories.CategoryFilterFactoryTest.CategoryFilterFactoryStub

cannot override createFilter(java.lang.Class<?>...) in
org.junit.experimental.categories.CategoryFilterFactory; overriding
method
is missing '...'
[ERROR]

/scratch/jenkins/workspace/JUnit/src/test/java/org/junit/experimental/categories/CategoryFilterFactoryTest.java:[45,25]

createFilter(java.lang.Class<?>[]) in

org.junit.experimental.categories.CategoryFilterFactoryTest.CategoryFilterFactoryStub

cannot override createFilter(java.lang.Class<?>...) in
org.junit.experimental.categories.CategoryFilterFactory; overriding
method
is missing '...'
[ERROR]

/scratch/jenkins/workspace/JUnit/src/test/java/org/junit/runner/FilterFactoriesTest.java:[68,9]

method does not override a method from its superclass
[ERROR]

/scratch/jenkins/workspace/JUnit/src/test/java/org/junit/runner/FilterFactoriesTest.java:[75,9]

method does not override a method from its superclass
[ERROR]

/scratch/jenkins/workspace/JUnit/src/test/java/org/junit/runner/JUnitCommandLineParseResultTest.java:[139,9]

method does not override a method from its superclass

—
Reply to this email directly or view it on GitHub<
https://github.com/junit-team/junit/pull/647#issuecomment-19007115>
.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/647#issuecomment-19015104
.

marcphilipp · 2013-06-06T05:22:02Z

It did not compile in Eclipse either. Now it does! I will merge #691.

@noel-yap Thanks! For the future, please check whether you can change your compiler settings in IntelliJ or use JDK5 to compile.

dsaff · 2014-11-18T16:22:59Z

I don't think this ever got added to the 4.12 release notes. It's a major feature in 4.12 (IMHO). Would anyone on this thread like to add it, or should I?

marcphilipp · 2014-11-22T18:43:31Z

@dsaff Do you have time to add this pull request to the release notes?

dsaff · 2014-11-24T17:04:45Z

Sure, I can do it in the next day or so.

marcphilipp · 2014-11-29T20:16:28Z

@dsaff Any news on this? I would not like to release 4.12 without this being documented.

dsaff · 2014-12-03T21:02:50Z

OK, sorry for the delay. Taking a look now.

dsaff · 2014-12-03T21:16:15Z

OK, tried my hand at a draft:

https://github.com/junit-team/junit/blob/master/doc/ReleaseNotes4.12.md#pull-request-647-support-command-line---filter-param

Thanks!

marcphilipp · 2014-12-04T06:44:23Z

LGTM, thanks!

--filter option implemented.

196c4ed

kcooney reviewed Mar 1, 2013
View reviewed changes

Changes due to suggestions from @kcooney.

0a9a389

kcooney reviewed Mar 2, 2013
View reviewed changes

JavaDoc added.

318adee

"--filter arg" support added (as opposed to "--filter=arg"). Command line parser factored into JUnitCommandLineParser class. Unit tests added.

Merge branch 'master' into filter-option

5edfb44

Conflicts: src/test/java/org/junit/tests/AllTests.java

kcooney reviewed Mar 10, 2013
View reviewed changes

noel-yap added 2 commits May 27, 2013 09:36

Responses to code review from @dsaff.

fa5df4e

Responses to code review from @dsaff.

b026c08

dsaff pushed a commit that referenced this pull request Jun 5, 2013

Merge pull request #647 from noel-yap/filter-option

aeaecd2

--filter option implemented.

dsaff merged commit aeaecd2 into junit-team:master Jun 5, 2013

stefanbirkner added this to the 4.12 milestone Dec 4, 2014

stefanbirkner added the feature label Dec 4, 2014

supersonicclay mentioned this pull request Nov 6, 2017

[Junit] Junit support for java debug microsoft/vscode-java-debug#76

Closed

--filter option implemented. #647

--filter option implemented. #647

Conversation

noel-yap commented Mar 1, 2013

kcooney Mar 1, 2013

Choose a reason for hiding this comment

noel-yap Mar 1, 2013

Choose a reason for hiding this comment

kcooney commented Mar 1, 2013

dsaff commented Mar 1, 2013

noel-yap commented Mar 1, 2013

noel-yap commented Mar 1, 2013

dsaff commented Mar 1, 2013

kcooney Mar 2, 2013

Choose a reason for hiding this comment

noel-yap Mar 4, 2013

Choose a reason for hiding this comment

dsaff commented Mar 7, 2013

kcooney Mar 10, 2013

Choose a reason for hiding this comment

noel-yap Mar 11, 2013

Choose a reason for hiding this comment

dsaff commented May 29, 2013

noel-yap commented Jun 4, 2013

dsaff commented Jun 5, 2013

marcphilipp commented Jun 5, 2013

noel-yap commented Jun 5, 2013

noel-yap commented Jun 5, 2013

marcphilipp commented Jun 5, 2013

noel-yap commented Jun 5, 2013

dsaff commented Jun 5, 2013

noel-yap commented Jun 5, 2013

marcphilipp commented Jun 5, 2013

noel-yap commented Jun 5, 2013

marcphilipp commented Jun 5, 2013

noel-yap commented Jun 5, 2013

kcooney commented Jun 6, 2013

marcphilipp commented Jun 6, 2013

dsaff commented Nov 18, 2014

marcphilipp commented Nov 22, 2014

dsaff commented Nov 24, 2014

marcphilipp commented Nov 29, 2014

dsaff commented Dec 3, 2014

dsaff commented Dec 3, 2014

marcphilipp commented Dec 4, 2014