Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #499 Assumes in tests run by Theories #601

Merged
merged 2 commits into from
Jan 10, 2013
Merged

Fix for issue #499 Assumes in tests run by Theories #601

merged 2 commits into from
Jan 10, 2013

Conversation

w25r
Copy link
Contributor

@w25r w25r commented Jan 8, 2013

Fixes an issue (#499) where Assume cannot be used in a method annotated
by @test if theories also exist in that test class.

@w25r
Fix for #499 Assumes in tests run by Theories
fbcebca 
Fixes an issue (#499) where Assume cannot be used in a method annotated
by @test if theories also exist in that test class.
dsaff
dsaff reviewed Jan 9, 2013
View reviewed changes
src/test/java/org/junit/tests/experimental/theories/AssumingInTheoriesTest.java
public class AssumingInTheoriesTest {

@Test
public void noTheoryAnnotationMeansAssumeShouldIgnore(){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of stylistic things:

  • Please always put spaces before {

@dsaff
Copy link
Member

dsaff commented Jan 9, 2013

Great!

Just a couple of stylistic issues to prevent unnecessary formatting changes down the road.

@w25r
Make stylistic changes
178f854 
Put { on first line with a space before it
@w25r
Copy link
Contributor Author

w25r commented Jan 9, 2013

Done. I think. Not sure I agree with not having detail messages in assertions, but it didn't add a lot in this particular case.

@dsaff
Copy link
Member

dsaff commented Jan 10, 2013

Thanks!

dsaff pushed a commit that referenced this pull request Jan 10, 2013
Merge pull request #601 from skazzyy/master
92a3f73 
Fix for issue #499 Assumes in tests run by Theories
@dsaff dsaff merged commit 92a3f73 into junit-team:master Jan 10, 2013
@dsaff
Copy link
Member

dsaff commented Jan 10, 2013

Thanks! Would you mind summarizing the change as well at https://github.com/KentBeck/junit/wiki/4.12-release-notes?

@w25r
Copy link
Contributor Author

w25r commented Jan 27, 2013

Done. Sorry for the delay.

On Thu, Jan 10, 2013 at 12:05 PM, David Saff [email protected]:

Thanks! Would you mind summarizing the change as well at
https://github.com/KentBeck/junit/wiki/4.12-release-notes?

—
Reply to this email directly or view it on GitHubhttps://github.com/KentBeck/junit/pull/601#issuecomment-12110105.

@dsaff
Copy link
Member

dsaff commented Jan 28, 2013

No problem. Thanks!

@UrsMetz UrsMetz mentioned this pull request Jul 29, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@w25r @dsaff