JavaDoc of TemperaryFolder: folder not guaranteed to be deleted #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * The TemporaryFolder Rule allows creation of files and folders that should | ||
| * be deleted when the test method finishes (whether it passes or | ||
| * fails). Whether the deletion is successful or not is not checked by this rule. | ||
| * No exception will be thrown in case the deletion fails: |
There was a problem hiding this comment.
Nits:
- end sentence with a period
- blank line (only a *) on the next line
- following line should be
<p>Example of usage:
|
Thanks! |
|
@kcooney I fixed the issues you pointed out, please have a look. |
|
LGTM! Please squash your commits. :-) |
UrsMetz
force-pushed
the
adjust-temporary-folder-javadoc
branch
from
999d8d1 to
b277169
Compare
UrsMetz
force-pushed
the
adjust-temporary-folder-javadoc
branch
from
b277169 to
93b08bc
Compare
|
@marcphilipp Done :-) |
kcooney
added a commit
that referenced
this pull request
Nov 7, 2014
JavaDoc of TemperaryFolder: folder not guaranteed to be deleted
|
@UrsMetz Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the JavaDoc of
TemporaryFolderto make it clear that the folders created by the rule are not guaranteed to be deleted after the test finishes, cf. discussion in #1001 and #616.