-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw TimeoutException when test fails with timeout #771
Comments
Sounds reasonable to me. Could you send us that in a pull request with a test? |
Hmm I'm on a tight schedule right now and I don't have your source code checked out. However if I can spare some time I will do so. Thanks for the reply! |
+1 for that |
👍 |
kcooney
added a commit
that referenced
this issue
Feb 18, 2014
Throw TestFailedOnTimeoutException instead of plain Exception on timeout. Fixes #771
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
FailOnTimeout.java contains the following statement:
I'd like to distinquish this exception from all the other exceptions. Could you please make it more specific, i.e.
TimeoutException
orTestFailedOnTimeoutException
rather than simply creating anException
? Is there a reason why the exception is not specific?The text was updated successfully, but these errors were encountered: