Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw TimeoutException when test fails with timeout #771

Closed
FRosner opened this issue Nov 22, 2013 · 4 comments
Closed

Throw TimeoutException when test fails with timeout #771

FRosner opened this issue Nov 22, 2013 · 4 comments

Comments

@FRosner
Copy link

FRosner commented Nov 22, 2013

FailOnTimeout.java contains the following statement:

Exception currThreadException = new Exception(String.format(
                "test timed out after %d %s", fTimeout, fTimeUnit.name().toLowerCase()));

I'd like to distinquish this exception from all the other exceptions. Could you please make it more specific, i.e. TimeoutException or TestFailedOnTimeoutException rather than simply creating an Exception? Is there a reason why the exception is not specific?

@kcooney
Copy link
Member

kcooney commented Nov 25, 2013

Sounds reasonable to me. Could you send us that in a pull request with a test?

@FRosner
Copy link
Author

FRosner commented Nov 25, 2013

Hmm I'm on a tight schedule right now and I don't have your source code checked out. However if I can spare some time I will do so.

Thanks for the reply!

@MartinSeeler
Copy link

+1 for that

@FRosner
Copy link
Author

FRosner commented Nov 29, 2013

👍

kcooney added a commit that referenced this issue Feb 18, 2014
Throw TestFailedOnTimeoutException instead of plain Exception on timeout. Fixes #771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants