Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IncludeCategory and ExcludeCategory should have plural in descriptive method value(): [] #336

Closed
Tibor17 opened this issue Oct 10, 2011 · 2 comments
Closed

IncludeCategory and ExcludeCategory should have plural in descriptive method value(): [] #336

Tibor17 opened this issue Oct 10, 2011 · 2 comments
Labels
feature

Comments

@Tibor17
Copy link
Contributor

Tibor17 commented Oct 10, 2011

It's used on suite and therefore it is reasonable to test against categories rather than one category.
The Category annotation already uses the plural. Backward compatibility is guaranteed.

If we accept this, it would be just easy to proceed with code changes in Catefories which would then expect a set of categories in fExcluded here instead of a sibgle value, and in an implementation of feature 307 as well. So I have already implemented symetric changes for both the fIncluded and fExcluded variables in Categories which is suited to both features in the same manner.

A static method
public static createCategoryFilter(Set<Class> includes, Set> excludes):CategoryFilter

should be added as an advantage to maven-surefire-plugin.
@dsaff
Copy link
Member

dsaff commented Oct 10, 2011

This makes sense to me. Let's be sure to be very clear in the specifications and tests about corner cases as they arise.

@Tibor17 Tibor17 mentioned this issue Oct 12, 2011
Closed
Tibor17 pushed a commit to Tibor17/junit that referenced this issue Oct 12, 2011
IncludeCategory and ExcludeCategory should have plural... (junit-team…
278afcb 
…#336)

This enables you to specify even more than one category on a suite.
IMHO the Javadoc on Categories is not in conflict with this feature.
Tibor17 pushed a commit to Tibor17/junit that referenced this issue Oct 28, 2011
This is the implementation for a feature of Configurable Categories
afa3930 
https://github.com/KentBeck/junit/issues/307

You can make a narrow list of tests in your build process according to build specifics.
See the test CategoriesConfiguredBySystemPropertiesTest.
There the suite accepts almost all tests of platforms, and the system properties suppress some of them.

Here we use a Set of categories which was necessary in this feature. Not using single values in variables fIncluded either fExcluded in Categories class. See their comments in code.

This way we have built also a prerequisite for junit-team#336. See 'TODO' and 'FIX for issue junit-team#336' in class Categories.
@Tibor17 Tibor17 mentioned this issue Oct 29, 2011
Merged
@Tibor17 Tibor17 mentioned this issue Feb 6, 2012
Closed
@Tibor17 Tibor17 mentioned this issue May 24, 2012
Open
@Tibor17 Tibor17 mentioned this issue Jul 14, 2012
Merged
@dsaff
Copy link
Member

dsaff commented Sep 20, 2013

I think we've finished this one off.

@dsaff dsaff closed this as completed Sep 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsaff @Tibor17