Fix shellescaping for git commands on Windows #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janlazo
force-pushed
the
shellescape-git
branch
from
0fac1bc to
fb7f63d
Compare
It was using s:esc() which escapes spaces with a backslash. This does not work on Windows.
&shell could be escaped on because of spaces. See patch-8.0.1455 and related 8.1.x patches that address this for $SHELL on Unix and git-bash on Windows.
janlazo
force-pushed
the
shellescape-git
branch
from
fb7f63d to
da128c4
Compare
janlazo
commented
Dec 2, 2019
| @@ -1169,7 +1169,7 @@ function! s:job_abort() | |||
| silent! call job_stop(j.jobid) | |||
| endif | |||
| if j.new | |||
| call s:system('rm -rf ' . plug#shellescape(g:plugs[name].dir)) | |||
| call s:rm_rf(g:plugs[name].dir) | |||
There was a problem hiding this comment.
s:rm_rf(dir) cannot run delete(a:dir, 'rf') without stalling the build. I guess it fails in the terminal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had issues installing/updating my plugins recently (ie.
Invalid URI, bad index on git) but it happens randomly for the same config. My guess is that vim-plug doesn't cleanup its temporary resources well on Windows and the shellescaping is not done correctly for all shell commands 😅 so issues like #690, #852, #908, #890 happen.Close #890